[WIP] [Draft] runtime-async Exception.ToString() #122722
Draft
+682
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new JIT-EE API to report back debug information about the generated state machine and continuations - Refactor debug info storage on VM side to be more easily extensible. The new format has either a thin or fat header. The fat header is used when we have either uninstrumented bounds, patchpoint info, rich debug info or async debug info, and stores the blob sizes of all of those components in addition to the bounds and vars. - Add new async debug information to the storage on the VM side - Set get target method desc for async resumption stubs, to be used for mapping from continuations back to the async IL function that it will resume.
…mental APIs in async tests
github-actions
bot
added
the
needs-area-label
am11
reviewed
Dec 24, 2025
am11
added
area-ExceptionHandling-coreclr
runtime-async
and removed
needs-area-label
am11
reviewed
Dec 24, 2025
| #ifndef __exkind_h__ | ||
| #define __exkind_h__ | ||
|
|
||
| #include <cstdint> |
Member
There was a problem hiding this comment.
Suggested change
| #include <cstdint> | |
| #include <cstdint> | |
| #include <functional> |
fixes the linux build include ordering issue, but you can also add it to vm/common.h around line 60 as this header isn't using template.
am11
reviewed
Dec 24, 2025
Comment on lines
+6
to
+7
| #ifndef __exkind_h__ | ||
| #define __exkind_h__ |
Member
There was a problem hiding this comment.
__ convention is for system headers. While we (incorrectly) use this convention in places, @janvorli has pointed out a few times that we should be using HAVE_<name> instead.
Suggested change
| #ifndef __exkind_h__ | |
| #define __exkind_h__ | |
| #ifndef HAVE_EXKIND_H | |
| #define HAVE_EXKIND_H |
am11
reviewed
Dec 24, 2025
| InstructionFaultFlag = 0x10 | ||
| }; | ||
|
|
||
| #endif // __exkind_h__ |
Member
There was a problem hiding this comment.
Suggested change
| #endif // __exkind_h__ | |
| #endif // HAVE_EXKIND_H |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.